|Author||Alex Forshtat, Yoav Weiss|
The proposal that had been accepted changes security properties of a large portion of an existing contract code base that may be infeasible to update and validate. This proposal will make the old assumptions hold even after a network upgrade.
EIP-1283 significantly lowers the gas costs of writing to contract’s storage. This created a danger of a new kind of reentrancy attacks on existing contracts as Solidity by default grants a ‘stipend’ of 2300 gas to simple transfer calls. This danger is easily mitigated if SSTORE is not allowed in low gasleft state, without breaking the backward compatibility and the original intention of this EIP.
An attack that is described in this article. Explicitly specifying the call stipend as an invariant will have a positive effect on Ethereum protocol security: https://www.reddit.com/r/ethereum/comments/agdqsm/security_alert_ethereum_constantinople/ee5uvjt
Add the following condition to to the SSTORE opcode gas cost calculation:
- If gasleft is less than or equal to 2300, fail the current call frame with ‘out of gas’ exception.
In order to keep in place the implicit reentrancy protection of existing contracts, transactions should not be allowed to modify state if the remaining gas is lower then the 2300 stipend given to ‘transfer’/’send’ in Solidity. These are other proposed remediations and objections to implementing them:
- Drop EIP-1283 and abstain from modifying SSTORE cost
- EIP-1283 is an important update
- It was accepted and implemented on test networks and in clients.
- Add a new call context that permits LOG opcodes but not changes to state.
- Adds another call type beyond existing regular/staticcall
- Raise the cost of SSTORE to dirty slots to >=2300 gas
- Makes net gas metering much less useful.
- Reduce the gas stipend
- Makes the stipend almost useless.
- Increase the cost of writes to dirty slots back to 5000 gas, but add 4800 gas to the refund counter
- Still doesn’t make the invariant explicit.
- Requires callers to supply more gas, just to have it refunded
- Add contract metadata specifying per-contract EVM version, and only apply SSTORE changes to contracts deployed with the new version.
Performing SSTORE has never been possible with less than 5000 gas, so it does not introduce incompatibility to the Ethereum mainnet. Gas estimation should account for this requirement.
Test cases for an implementation are mandatory for EIPs that are affecting consensus changes. Other EIPs can choose to include links to test cases if applicable. TODO
Copyright and related rights waived via CC0.