Do not erase gas refunds on transaction subcall reverts, due users pay a lot of gas for storage non-modification.
|Author||Anton Bukov, Mikhail Melnik|
Table of Contents
Since EIP-3298 gas refunds works for storage restores only inside the same transaction. For example ERC-20
transferFrom flow between 2 smart contracts according to EIP-2200 and EIP-2929 will cost nearly to
21600 gas with gas refund counter
20000. But in case of reverting this subcall (containing both
transferForm) gas refund will be erased, while smart contract storage will remain unmodified. I think it should keep storage access costs, but still refund modification costs.
Сurrent full cancelling of gas refunds on internal reverts is too unfair. Users pay for non-modification same cost as for modification.
Let’s count all SSTORE gas costs within every subcall, excluding access costs. And on reverting any subcall let’s not erase refund counter, but:
tx.gas_refund_counter = tx.gas_refund_counter - call.gas_refund_counter + MIN(call.gas_refund_counter, call.all_sstores_gas_cost)
No known backward incompatibilities.
Copyright and related rights waived via CC0.
Please cite this document as: